Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test consensus: merging, ver 2 #9193

Merged
merged 26 commits into from
Mar 14, 2025
Merged

Conversation

archibald1418
Copy link
Contributor

@archibald1418 archibald1418 commented Mar 10, 2025

Depends on #9178

Motivation and context

Test coverage for merging feature in consensus jobs (#8953)
Commits were cherry-picked from #9190

How has this been tested?

Case 1: check new merge buttons exist and are visible.

New freshly created jobs have status 'new'. Trying to merge new jobs should result in error notifications and a HTTP 400 status code. All notifications are closed before the next testcase

Case 2: Check consensus management page

Consensus management page has settings for consensus quorum and minimum annotation overlap. Check that the page has fields for both options. If a field is filled incorrectly the form turns red and a message appears under the form. Trying to save options with erroneous forms should do nothing - no requests are sent, no errors shown.

Case 3: Create annotations and check that job replicas merge correctly

Create annotations with one rectangle in job replicas. The rectangle is moved with a step in each job's first frame. This means that after merging, the consensus job will have a rectangle which has to fully match a rectangle inside the replica in the middle.

  • Create annotations.
  • Merge consensus jobs. No errors should appear. A notification message validates the merge, close it
  • Go inside consensus job, remember the rectangle's positions
  • Go back to the task page using browser's 'Back' button
  • After loading the task page, consensus job's status should read competed
  • Open the middle job replica. Rectangle should be identical to the previous one

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@archibald1418 archibald1418 removed the request for review from bsekachev March 10, 2025 14:47
@archibald1418 archibald1418 mentioned this pull request Mar 10, 2025
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.64%. Comparing base (39bcc6a) to head (3aa9ca5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9193      +/-   ##
===========================================
+ Coverage    73.38%   73.64%   +0.25%     
===========================================
  Files          450      450              
  Lines        45847    45847              
  Branches      3917     3917              
===========================================
+ Hits         33645    33762     +117     
+ Misses       12202    12085     -117     
Components Coverage Δ
cvat-ui 77.66% <ø> (+0.57%) ⬆️
cvat-server 70.41% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@archibald1418 archibald1418 requested a review from klakhov March 10, 2025 19:44
@archibald1418 archibald1418 requested a review from klakhov March 12, 2025 10:36
@archibald1418 archibald1418 requested a review from klakhov March 12, 2025 18:36
@archibald1418 archibald1418 requested a review from klakhov March 13, 2025 19:05
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archibald1418 archibald1418 merged commit d386ffa into develop Mar 14, 2025
34 checks passed
@archibald1418 archibald1418 deleted the ov/test-consensus-merge-ver2 branch March 14, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants