-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test consensus: merging, ver 2 #9193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9193 +/- ##
===========================================
+ Coverage 73.38% 73.64% +0.25%
===========================================
Files 450 450
Lines 45847 45847
Branches 3917 3917
===========================================
+ Hits 33645 33762 +117
+ Misses 12202 12085 -117
🚀 New features to boost your workflow:
|
klakhov
reviewed
Mar 11, 2025
cvat-ui/src/components/consensus-management-page/consensus-settings-tab.tsx
Outdated
Show resolved
Hide resolved
klakhov
reviewed
Mar 12, 2025
Co-authored-by: Kirill Lakhov <[email protected]>
Co-authored-by: Kirill Lakhov <[email protected]>
klakhov
reviewed
Mar 13, 2025
|
klakhov
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9178
Motivation and context
Test coverage for merging feature in consensus jobs (#8953)
Commits were cherry-picked from #9190
How has this been tested?
Case 1: check new merge buttons exist and are visible.
New freshly created jobs have status 'new'. Trying to merge new jobs should result in error notifications and a HTTP 400 status code. All notifications are closed before the next testcase
Case 2: Check consensus management page
Consensus management page has settings for consensus quorum and minimum annotation overlap. Check that the page has fields for both options. If a field is filled incorrectly the form turns red and a message appears under the form. Trying to save options with erroneous forms should do nothing - no requests are sent, no errors shown.
Case 3: Create annotations and check that job replicas merge correctly
Create annotations with one rectangle in job replicas. The rectangle is moved with a step in each job's first frame. This means that after merging, the consensus job will have a rectangle which has to fully match a rectangle inside the replica in the middle.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.